Add Config::loadSystemConfigBlocking() to load default system config#93
Merged
jsor merged 1 commit intoreactphp:masterfrom Feb 26, 2018
Merged
Add Config::loadSystemConfigBlocking() to load default system config#93jsor merged 1 commit intoreactphp:masterfrom
jsor merged 1 commit intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Feb 25, 2018
jsor
approved these changes
Feb 26, 2018
This was referenced Feb 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR adds the skeleton for loading the default system config. As per #29 (comment) it does not actually load any configuration, it merely adds the API that should be consumed to load the configuration. This PR mostly exists to discuss this API and to give an idea how this can be consumed.
It also adds documentation that a
Configmay be empty, which makes sense for a number of reasons. Once this PR is in, I will update #92 to use this API so that the/etc/resolv.confwill be loaded as expected. Once this is in, I will file a PR to add Windows support and consider this feature complete for now.Refs #29
Refs #92